Skip to content

Archlinux client and server package names were swapped around #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

Archlinux client and server package names were swapped around #1381

merged 1 commit into from
Jan 27, 2023

Conversation

tobixen
Copy link
Contributor

@tobixen tobixen commented Jan 8, 2023

(subject says it all)

@tobixen tobixen requested a review from a team as a code owner January 8, 2023 11:46
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

postgresql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 3 modules (near match):

This module is declared in 70 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@tobixen
Copy link
Contributor Author

tobixen commented Jan 8, 2023

This seems unrelated to my patch, and I don't understand much of this:

Failures:
832

833
  1) postgresql::server::default_privileges valid object_type schemas on postgres < 10.0 
834
     Got 0 failures and 2 other errors:
835

836
     1.1) Failure/Error: result_facts.merge!(munge_facts(facts)) if self.respond_to?(:facts)
837

838
          TypeError:
839
            no implicit conversion of nil into Hash
840
          # ./vendor/bundle/ruby/2.5.0/bin/rspec:23:in `load'
841
          # ./vendor/bundle/ruby/2.5.0/bin/rspec:23:in `<top (required)>'
842
          # /opt/hostedtoolcache/Ruby/2.5.9/x64/bin/bundle:23:in `load'
843
          # /opt/hostedtoolcache/Ruby/2.5.9/x64/bin/bundle:23:in `<main>'
844

845
     1.2) Failure/Error: @logs.clear
846

847
          NoMethodError:
848
            undefined method `clear' for nil:NilClass
849
          # ./vendor/bundle/ruby/2.5.0/bin/rspec:23:in `load'
850
          # ./vendor/bundle/ruby/2.5.0/bin/rspec:23:in `<top (required)>'
851
          # /opt/hostedtoolcache/Ruby/2.5.9/x64/bin/bundle:23:in `load'
852
          # /opt/hostedtoolcache/Ruby/2.5.9/x64/bin/bundle:23:in `<main>'
853

@ekohl ekohl changed the title bugfix - client and server package names were swapped around Archlinux client and server package names were swapped around Jan 10, 2023
@ekohl ekohl added the bugfix label Jan 10, 2023
@ekohl ekohl requested a review from bastelfreak January 10, 2023 11:45
bastelfreak
bastelfreak approved these changes Jan 11, 2023
View reviewed changes
@chelnak chelnak merged commit 0b96216 into puppetlabs:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonHoenscheid SimonHoenscheid SimonHoenscheid left review comments

@bastelfreak bastelfreak bastelfreak approved these changes

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tobixen @CLAassistant @bastelfreak @chelnak @SimonHoenscheid @ekohl @ia-content